Skip to content

fix: NetworkShowHideTests fail on HideThenShowAndRpc#2400

Merged
NoelStephensUnity merged 13 commits intodevelopfrom
fix/networkshowhidetests-fail-on-hidethenshowandrpc
Feb 6, 2023
Merged

fix: NetworkShowHideTests fail on HideThenShowAndRpc#2400
NoelStephensUnity merged 13 commits intodevelopfrom
fix/networkshowhidetests-fail-on-hidethenshowandrpc

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity commented Jan 31, 2023 •
edited
Loading

This includes a fix for WaitForTicks related failures on slower or processor bound systems.
This excludes NestedNetworkTransformTests due to occasional issues with stability associated with lerping and not slerping when moving children in a circular pattern around their parent.

Testing

@NoelStephensUnity
test fix
52abef4 
Fixing issue where slower or overbooked VM systems could potentially fail on the last NetworkShowHideTest (HideThenShowAndRPC).
@NoelStephensUnity
test
02576fb 
Adding comment
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 31, 2023 23:04
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner January 31, 2023 23:04
@NoelStephensUnity NoelStephensUnity marked this pull request as draft January 31, 2023 23:15
@NoelStephensUnity
update
2c98346 
Experimenting with NetcodeIntegrationTestHelpers.WaitForTicks
@NoelStephensUnity
style
7d299ae
@NoelStephensUnity
style
0ad0792 
renamed a method for better clarity
@NoelStephensUnity
update
25010f9 
Adding some additional log information for better clarity of which NetworkManager instance is waiting.
@NoelStephensUnity
fix
79a90cf 
There was something about waiting until the end of frame that caused issues.
@NoelStephensUnity
update
c8daab6 
Migrating WaitForTicks update into NetcodeIntegraitonTest
Updating all reference to migrated WaitForTicks.
@NoelStephensUnity
Merge branch 'develop' into fix/networkshowhidetests-fail-on-hidethen…
0092a98 
…showandrpc
@NoelStephensUnity
update
d753fb1 
Adding comments and updating some of the code for better clarity purposes.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review February 1, 2023 22:49
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) February 1, 2023 22:50
@NoelStephensUnity
test
e3e75b5 
disabling nested network transform tests until PR-2388 is merged (it resolves all of the instability issues)
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) February 2, 2023 00:05
NoelStephensUnity and others added 2 commits February 1, 2023 19:10
@NoelStephensUnity
Merge branch 'develop' into fix/networkshowhidetests-fail-on-hidethen…
28959d2 
…showandrpc
@NoelStephensUnity
test fix
ee56705 
Looks like NetworkAnimatorTests were failing due to the NestedNetworkTransform scene possibly not being unloaded.  Doing a full #if to exclude NestedNetworkTransformTests completely until PR-2388 updates are merged.
@NoelStephensUnity NoelStephensUnity merged commit 66b11d0 into develop Feb 6, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/networkshowhidetests-fail-on-hidethenshowandrpc branch February 6, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffreyrainy jeffreyrainy jeffreyrainy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoelStephensUnity @jeffreyrainy